Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp compute resources documentation #4770

Merged
merged 1 commit into from
May 3, 2022
Merged

Revamp compute resources documentation #4770

merged 1 commit into from
May 3, 2022

Conversation

lbernick
Copy link
Member

Changes

This commit updates Tekton documentation on compute resources.
It separates Kubernetes background into a separate section, describes how
resource requests differ in Tekton and in Kubernetes, adds examples for
LimitRange, and adds details for ResourceQuotas.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • n/a Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@lbernick
Revamp compute resources documentation
f7723e5 
This commit updates Tekton documentation on compute resources.
It separates Kubernetes background into a separate section, describes how
resource requests differ in Tekton and in Kubernetes, adds examples for
LimitRange, and adds details for ResourceQuotas.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Apr 18, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2022
@lbernick
Copy link
Member Author

/assign @vdemeester
/assign @leeonlee

@tekton-robot
Copy link
Collaborator

@lbernick: GitHub didn't allow me to assign the following users: leeonlee.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @vdemeester
/assign @leeonlee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lbernick
Copy link
Member Author

This PR describes the behavior of LimitRange support as modified in #4769

leeonlee
leeonlee approved these changes Apr 19, 2022
View reviewed changes
Copy link

@leeonlee leeonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@vdemeester
Copy link
Member

/hold
Let's wait for #4769 to be merged then 🙃

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2022
@lbernick
Copy link
Member Author

lbernick commented May 2, 2022

/test pull-tekton-pipeline-build-tests

@lbernick
Copy link
Member Author

lbernick commented May 3, 2022

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2022
vdemeester
vdemeester approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, leeonlee, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit bceff42 into tektoncd:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@leeonlee leeonlee leeonlee approved these changes

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbernick @tekton-robot @vdemeester @leeonlee @dibyom